[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/8] migration: Open brace '{' following function declarat
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH v2 7/8] migration: Open brace '{' following function declarations go on the next line |
Date: |
Wed, 14 Oct 2020 20:26:13 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
* Bihong Yu (yubihong@huawei.com) wrote:
> Signed-off-by: Bihong Yu <yubihong@huawei.com>
> Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/rdma.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/migration/rdma.c b/migration/rdma.c
> index 0eb42b7..ca4d315 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -273,7 +273,8 @@ static uint64_t htonll(uint64_t v)
> return u.llv;
> }
>
> -static uint64_t ntohll(uint64_t v) {
> +static uint64_t ntohll(uint64_t v)
> +{
> union { uint32_t lv[2]; uint64_t llv; } u;
> u.llv = v;
> return ((uint64_t)ntohl(u.lv[0]) << 32) | (uint64_t) ntohl(u.lv[1]);
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- Re: [PATCH v2 1/8] migration: Do not use C99 // comments, (continued)
[PATCH v2 4/8] migration: Open brace '{' following struct go on the same line, Bihong Yu, 2020/10/12
[PATCH v2 6/8] migration: Do not initialise statics and globals to 0 or NULL, Bihong Yu, 2020/10/12
[PATCH v2 7/8] migration: Open brace '{' following function declarations go on the next line, Bihong Yu, 2020/10/12
- Re: [PATCH v2 7/8] migration: Open brace '{' following function declarations go on the next line,
Dr. David Alan Gilbert <=
[PATCH v2 5/8] migration: Add braces {} for if statement, Bihong Yu, 2020/10/12
[PATCH v2 8/8] migration: Delete redundant spaces, Bihong Yu, 2020/10/12