[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/10] Fix line over 80 characters warning
From: |
Peter Maydell |
Subject: |
Re: [PATCH 00/10] Fix line over 80 characters warning |
Date: |
Tue, 20 Oct 2020 12:14:51 +0100 |
On Tue, 20 Oct 2020 at 12:03, Gan Qixin <ganqixin@huawei.com> wrote:
>
> Hi all,
> I used scripts/checkpatch.pl to find that many files in the hw directory
> contain lines with more than 80 characters. Therefore, I splited some lines to
> fix this warning.
I personally have come round to the idea that we should instead
adjust checkpatch so that it doesn't have a hard 80 character
complaint limit.
Compare the kernel coding style change:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144
whose rationale I agree with. We should *prefer* 80 character
wrapping, but there are some places where an 85-character
line is much more readable and sensible style than inserting
a line break just to please checkpatch.
thanks
-- PMM
- [PATCH 00/10] Fix line over 80 characters warning, Gan Qixin, 2020/10/20
- Re: [PATCH 00/10] Fix line over 80 characters warning, Daniel P . Berrangé, 2020/10/20
- Re: [PATCH 00/10] Fix line over 80 characters warning,
Peter Maydell <=
- [PATCH 03/10] hw/ide/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 06/10] hw/pci/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 09/10] hw/input/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 04/10] hw/intc/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 05/10] hw/misc/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 01/10] hw/virtio/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 07/10] hw/pci-host/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 02/10] hw/core/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 08/10] hw/char/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20