[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/8] elf2dmp: Fix memory leak on main() error paths
From: |
Laurent Vivier |
Subject: |
[PULL 1/8] elf2dmp: Fix memory leak on main() error paths |
Date: |
Tue, 27 Oct 2020 17:30:07 +0100 |
From: AlexChen <alex.chen@huawei.com>
The 'kdgb' is allocating memory in get_kdbg(), but it is not freed
in both fill_header() and fill_context() failed branches, fix it.
Signed-off-by: AlexChen <alex.chen@huawei.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <5F463659.8080101@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
contrib/elf2dmp/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c
index 9a2dbc290214..ac746e49e097 100644
--- a/contrib/elf2dmp/main.c
+++ b/contrib/elf2dmp/main.c
@@ -568,12 +568,12 @@ int main(int argc, char *argv[])
if (fill_header(&header, &ps, &vs, KdDebuggerDataBlock, kdbg,
KdVersionBlock, qemu_elf.state_nr)) {
err = 1;
- goto out_pdb;
+ goto out_kdbg;
}
if (fill_context(kdbg, &vs, &qemu_elf)) {
err = 1;
- goto out_pdb;
+ goto out_kdbg;
}
if (write_dump(&ps, &header, argv[2])) {
--
2.26.2
- [PULL 0/8] Trivial branch for 5.2 patches, Laurent Vivier, 2020/10/27
- [PULL 2/8] Makefile: Add *.[ch].inc files to cscope/ctags/TAGS, Laurent Vivier, 2020/10/27
- [PULL 3/8] cpus: Drop declaration of cpu_remove(), Laurent Vivier, 2020/10/27
- [PULL 4/8] io: Fix Lesser GPL version number, Laurent Vivier, 2020/10/27
- [PULL 5/8] cryptodev: Fix Lesser GPL version number, Laurent Vivier, 2020/10/27
- [PULL 6/8] scripts/qmp: delete 'qmp' script, Laurent Vivier, 2020/10/27
- [PULL 7/8] qdev: Fix two typos, Laurent Vivier, 2020/10/27
- [PULL 8/8] CHANGELOG: remove disused file, Laurent Vivier, 2020/10/27
- [PULL 1/8] elf2dmp: Fix memory leak on main() error paths,
Laurent Vivier <=
- Re: [PULL 0/8] Trivial branch for 5.2 patches, Peter Maydell, 2020/10/30