[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/9] target/ppc: silence the compiler warnings
From: |
Thomas Huth |
Subject: |
Re: [PATCH 8/9] target/ppc: silence the compiler warnings |
Date: |
Wed, 28 Oct 2020 16:06:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 28/10/2020 10.56, Philippe Mathieu-Daudé wrote:
> On 10/28/20 5:18 AM, Chen Qun wrote:
>> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
>> target/ppc/mmu_helper.c: In function ‘dump_mmu’:
>> target/ppc/mmu_helper.c:1351:12: warning: this statement may fall through
>> [-Wimplicit-fallthrough=]
>> 1351 | if (ppc64_v3_radix(env_archcpu(env))) {
>> | ^
>> target/ppc/mmu_helper.c:1358:5: note: here
>> 1358 | default:
>> | ^~~~~~~
>>
>> Add the corresponding "fall through" comment to fix it.
>>
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
>> ---
>> Cc: David Gibson <david@gibson.dropbear.id.au>
>> ---
>> target/ppc/mmu_helper.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c
>> index 8972714775..51749b62df 100644
>> --- a/target/ppc/mmu_helper.c
>> +++ b/target/ppc/mmu_helper.c
>> @@ -1355,6 +1355,7 @@ void dump_mmu(CPUPPCState *env)
>> break;
>> }
>> #endif
>> + /* fall through */
>
> I'm surprise the compiler emit a warning for missing comment,
> but don't emit one for superfluous and confusing ones (when
> building a ppc32-only target). You'd need to put this before
> the #endif.
>
> But instead of this band-aid to silent warning, replace the
> TODO by a LOG_UNIMP call, and add a break before the #endif.
+1 for replacing the TODO with a LOG_UNIMP call and adding a break instead,
that would look way less messy than the current code.
Thanks,
Thomas
- Re: [PATCH 1/9] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, (continued)
Re: [PATCH 1/9] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, Richard Henderson, 2020/10/28
[PATCH 4/9] linux-user/mips/cpu_loop: silence the compiler warnings, Chen Qun, 2020/10/28
[PATCH 8/9] target/ppc: silence the compiler warnings, Chen Qun, 2020/10/28
[PATCH 9/9] hw/timer/renesas_tmr: silence the compiler warnings, Chen Qun, 2020/10/28
RE: [PATCH 9/9] hw/timer/renesas_tmr: silence the compiler warnings, Chenqun (kuhn), 2020/10/29
[PATCH 3/9] accel/tcg/user-exec: silence the compiler warnings, Chen Qun, 2020/10/28