[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/8] accel/tcg/user-exec: silence the compiler warnings
From: |
Thomas Huth |
Subject: |
Re: [PATCH v2 3/8] accel/tcg/user-exec: silence the compiler warnings |
Date: |
Fri, 30 Oct 2020 16:40:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 30/10/2020 01.40, Chen Qun wrote:
> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
> ../accel/tcg/user-exec.c: In function ‘handle_cpu_signal’:
> ../accel/tcg/user-exec.c:169:13: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
> 169 | cpu_exit_tb_from_sighandler(cpu, old_set);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../accel/tcg/user-exec.c:172:9: note: here
> 172 | default:
>
> Mark the cpu_exit_tb_from_sighandler() function with QEMU_NORETURN to fix it.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
> v1->v2: Add QEMU_NORETURN to cpu_exit_tb_from_sighandler() function
> to avoid the compiler warnings(Base on Thomas's and Richard's comments).
>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Riku Voipio <riku.voipio@iki.fi>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> ---
> accel/tcg/user-exec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c
> index 4ebe25461a..293ee86ea4 100644
> --- a/accel/tcg/user-exec.c
> +++ b/accel/tcg/user-exec.c
> @@ -49,7 +49,8 @@ __thread uintptr_t helper_retaddr;
> /* exit the current TB from a signal handler. The host registers are
> restored in a state compatible with the CPU emulator
> */
> -static void cpu_exit_tb_from_sighandler(CPUState *cpu, sigset_t *old_set)
> +static void QEMU_NORETURN cpu_exit_tb_from_sighandler(CPUState *cpu,
> + sigset_t *old_set)
> {
> /* XXX: use siglongjmp ? */
> sigprocmask(SIG_SETMASK, old_set, NULL);
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
- [PATCH v2 0/8] silence the compiler warnings, Chen Qun, 2020/10/29
- [PATCH v2 4/8] linux-user/mips/cpu_loop: silence the compiler warnings, Chen Qun, 2020/10/29
- [PATCH v2 3/8] accel/tcg/user-exec: silence the compiler warnings, Chen Qun, 2020/10/29
- [PATCH v2 1/8] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, Chen Qun, 2020/10/29
- [PATCH v2 8/8] target/ppc: replaced the TODO with LOG_UNIMP and add break for silence warnings, Chen Qun, 2020/10/29
- [PATCH v2 2/8] hw/intc/arm_gicv3_kvm: silence the compiler warnings, Chen Qun, 2020/10/29
- [PATCH v2 5/8] target/sparc/translate: silence the compiler warnings, Chen Qun, 2020/10/29
- [PATCH v2 7/8] ppc: Add a missing break for PPC6xx_INPUT_TBEN, Chen Qun, 2020/10/29