[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2] hw/display/exynos4210_fimd: Fix potential NULL pointer de
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH V2] hw/display/exynos4210_fimd: Fix potential NULL pointer dereference |
|
Date: |
Mon, 2 Nov 2020 10:16:52 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 11/2/20 5:39 AM, AlexChen wrote:
> In exynos4210_fimd_update(), the pointer s is dereferinced before
Typo dereferinced -> dereferenced.
> being check if it is valid, which may lead to NULL pointer dereference.
> So move the assignment to global_width after checking that the s is valid.
Easier to read "after checking 's' is valid."
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Alex Chen <alex.chen@huawei.com>
> ---
> hw/display/exynos4210_fimd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>