Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category

[Philippe Mathieu-Daudé]

Hi Gan,

On 11/15/20 7:49 PM, Gan Qixin wrote:
> Some peripherals of bcm2835 cprman have no category, put them into the 'misc'
> category.
> 
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/misc/bcm2835_cprman.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/hw/misc/bcm2835_cprman.c b/hw/misc/bcm2835_cprman.c
> index 7e415a017c..c62958a99e 100644
> --- a/hw/misc/bcm2835_cprman.c
> +++ b/hw/misc/bcm2835_cprman.c
> @@ -136,6 +136,7 @@ static void pll_class_init(ObjectClass *klass, void *data)
>  
>      dc->reset = pll_reset;
>      dc->vmsd = &pll_vmstate;
> +    set_bit(DEVICE_CATEGORY_MISC, dc->categories);

Well, this is not an usable device but a part of a bigger device,
so here we want the opposite: not list this device in any category.

Maybe we could add a DEVICE_CATEGORY_COMPOSITE for all such QOM
types so management apps can filter them out? (And so we are sure
all QOM is classified).

Thomas, you already dealt with categorizing devices in the past,
what do you think about this? Who else could help? Maybe add
someone from libvirt in the thread?

>  }
>  
>  static const TypeInfo cprman_pll_info = {
> @@ -239,6 +240,7 @@ static void pll_channel_class_init(ObjectClass *klass, 
> void *data)
>  
>      dc->reset = pll_channel_reset;
>      dc->vmsd = &pll_channel_vmstate;
> +    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
>  }
>  
>  static const TypeInfo cprman_pll_channel_info = {
> @@ -359,6 +361,7 @@ static void clock_mux_class_init(ObjectClass *klass, void 
> *data)
>  
>      dc->reset = clock_mux_reset;
>      dc->vmsd = &clock_mux_vmstate;
> +    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
>  }
>  
>  static const TypeInfo cprman_clock_mux_info = {
> @@ -411,6 +414,7 @@ static void dsi0hsck_mux_class_init(ObjectClass *klass, 
> void *data)
>      DeviceClass *dc = DEVICE_CLASS(klass);
>  
>      dc->vmsd = &dsi0hsck_mux_vmstate;
> +    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
>  }
>  
>  static const TypeInfo cprman_dsi0hsck_mux_info = {
>