Re: [PATCH] meson: Only generate trace files for selected targets

[Philippe Mathieu-Daudé]

On 2/24/21 2:11 PM, Peter Maydell wrote:
> On Wed, 24 Feb 2021 at 12:11, Philippe Mathieu-Daudé <philmd@redhat.com> 
> wrote:
>>
>> We don't need to generate trace files for targets we
>> are not building. Restrict the the ones selected.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  meson.build | 10 +---------
>>  1 file changed, 1 insertion(+), 9 deletions(-)
>>
>> diff --git a/meson.build b/meson.build
>> index 05a67c20d93..c9b0433667d 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -1826,15 +1826,6 @@
>>    trace_events_subdirs += [
>>      'accel/tcg',
>>      'hw/core',
>> -    'target/arm',
>> -    'target/hppa',
>> -    'target/i386',
>> -    'target/i386/kvm',
>> -    'target/mips',
>> -    'target/ppc',
>> -    'target/riscv',
>> -    'target/s390x',
>> -    'target/sparc',
>>    ]
>>  endif
>>
>> @@ -2166,6 +2157,7 @@
>>    t = target_arch[arch].apply(config_target, strict: false)
>>    arch_srcs += t.sources()
>>    arch_deps += t.dependencies()
>> +  trace_events_subdirs += ['target' / arch]
> 
> This will catch all the 'target/foo' entries deleted above,
> but what about 'target/i386/kvm' ?

Yes, this doesn't work as expected... I just figured it was
working in my build directories because the trace header
previously generated are still present. I should have tested
in an empty directory before posting.

Regards,

Phil.