qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] meson: Propagate gnutls dependency to migration


From: Paolo Bonzini
Subject: Re: [PATCH v2] meson: Propagate gnutls dependency to migration
Date: Wed, 24 Mar 2021 14:45:00 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 20/03/21 18:12, Jessica Clarke wrote:
Commit 3eacf70bb5a83e4775ad8003cbca63a40f70c8c2 neglected to fix this
for softmmu configs, which pull in migration's use of gnutls.

This fixes the following compilation failure on Arm-based Macs:

   In file included from migration/multifd.c:23:
   In file included from migration/tls.h:25:
   In file included from include/io/channel-tls.h:26:
   In file included from include/crypto/tlssession.h:24:
   include/crypto/tlscreds.h:28:10: fatal error: 'gnutls/gnutls.h' file not 
found
   #include <gnutls/gnutls.h>
            ^~~~~~~~~~~~~~~~~
   1 error generated.

(as well as for channel.c and tls.c)

Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
---
Changes in v2:
  * Added error to commit message

  migration/meson.build | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/meson.build b/migration/meson.build
index 9645f44005..6fa2f8745d 100644
--- a/migration/meson.build
+++ b/migration/meson.build
@@ -24,7 +24,7 @@ softmmu_ss.add(files(
    'savevm.c',
    'socket.c',
    'tls.c',
-))
+), gnutls)
softmmu_ss.add(when: ['CONFIG_RDMA', rdma], if_true: files('rdma.c'))
  softmmu_ss.add(when: 'CONFIG_LIVE_BLOCK_MIGRATION', if_true: files('block.c'))


Queued, thanks.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]