[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] spapr_pci: fix leak in spapr_phb_vfio_get_loc_code
From: |
Paolo Bonzini |
Subject: |
[PATCH] spapr_pci: fix leak in spapr_phb_vfio_get_loc_code |
Date: |
Mon, 5 Sep 2022 12:17:57 +0200 |
Overwriting "path" in the second call to g_strdup_printf() causes a memory leak,
even if the variable itself is g_autofree.
Reported by Coverity as CID 1460454.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/ppc/spapr_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 67e9d468aa..57c8a4f085 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -800,6 +800,7 @@ static char *spapr_phb_vfio_get_loc_code(SpaprPhbState
*sphb, PCIDevice *pdev)
}
/* Construct and read from host device tree the loc-code */
+ g_free(path);
path = g_strdup_printf("/proc/device-tree%s/ibm,loc-code", devspec);
if (!g_file_get_contents(path, &buf, NULL, NULL)) {
return NULL;
--
2.37.2
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] spapr_pci: fix leak in spapr_phb_vfio_get_loc_code,
Paolo Bonzini <=