Re: [Quilt-dev] Fix mode on backup files

[Dean Roehrich]

>From:  Andreas Gruenbacher <address@hidden>

>> @@ -239,7 +240,7 @@
>>                      if (link_or_copy(file, &st, backup))
>>                              return 1;
>>                      if (opt_nolinks) {
>> -                            if (ensure_nolinks(file))
>> +                            if (ensure_nolinks(backup))
>>                                      return 1;
>
>The idea here was to ensure that the original file doesn't have more
>than one hardlink after a patch touches it (or after a patch is
>removed). This makes it a lot less likely that a file is modified while
>its backup file is modified at the same time. I don't understand why
>that would matter for the backup file.

Perhaps in the what_backup case we should call ensure_nolinks for both the
original and the backup?

I'm thinking about the case where someone edits one of the other links,
without having used 'quilt add' on it, and now the backup has changed, and the
patch won't pop cleanly...

Dean