[Quilt-dev] [patch] Incorrect user output when a patch touches only files beginning with a dot

[James Rowe]

From: James Rowe <address@hidden>
Severity: Minor
Status: Done
Section: !avail
Conflicts: filedir-perms-metadata-support.patch
Closes: #594271

  Patches that only touch files beginning with a `.', are incorrectly reported
to be empty.

  Policy issue?  Probably, but the bug still exists.

---

 apatch.in |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

--- quilt-0.35/scripts/apatch.in        2004-07-15 23:02:46.000000000 +0100
+++ quilt-0.35/scripts/apatch.in        2004-08-30 05:24:49.069229152 +0100
@@ -112,7 +112,7 @@ apatch()
                        touch $QUILT_PC/$patch/.timestamp
                fi
 
-               if [ "$(shopt -s nullglob ; echo $QUILT_PC/$patch/*)" = "" ]
+               if [ -z "$(ls -A $QUILT_PC/$patch/*)" ]
                then
                        printf $"Patch %s appears to be empty, applied\n" \
                               "$(print_patch $patch)"


-- 

Public key: http://www.jnrowe.ukfsn.org/files/gpg.asc
            http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xD1279738
Key fingerprint: 7721 D12B 822B 20FE FCE6  B2B7 7CDF C9DF D16A 87D7

"A computer lets you make more mistakes faster than any invention in
human history... with the possible exception of handguns and tequila." - Anon.

signature.asc
Description: Digital signature