Re: [Quilt-dev] Stripped backup-files needed?

[Andreas Gruenbacher]

On Friday 04 November 2005 14:43, Josh Boyer wrote:
> Comments on this?  Can I commit the patch attached in the bug?

I agree with this change. Are you fine with this commit?

Index: quilt.changes
===================================================================
RCS file: /cvsroot/quilt/quilt/quilt.changes,v
retrieving revision 1.317
diff -u -r1.317 quilt.changes
--- quilt.changes       12 Oct 2005 14:30:52 -0000      1.317
+++ quilt.changes       4 Nov 2005 15:24:34 -0000
@@ -1,4 +1,12 @@
 -------------------------------------------------------------------
+Fri Nov  4 16:21:58 CET 2005 - address@hidden
+
+- Makefile.in: don't strip the backup-files binary in the install
+  target.
+- quilt.spec.in: set the CFLAGS to $RPM_OPT_FLAGS, and pass on
+  the RPM release number when building quilt.
+
+-------------------------------------------------------------------
 Wed Oct 12 15:33:53 CEST 2005 - address@hidden
 
 - scripts/inspect.in: remove unnecessary path_search() function
Index: Makefile.in
===================================================================
RCS file: /cvsroot/quilt/quilt/Makefile.in,v
retrieving revision 1.93
diff -u -r1.93 Makefile.in
--- Makefile.in 22 Sep 2005 18:40:50 -0000      1.93
+++ Makefile.in 4 Nov 2005 15:24:34 -0000
@@ -289,7 +289,7 @@
        $(INSTALL) -m 644 scripts/patchfns $(BUILD_ROOT)$(SCRIPTS_DIR)
 
        $(INSTALL) -d $(BUILD_ROOT)$(LIB_DIR)
-       $(INSTALL) -m 755 -s $(LIB:%=lib/%) $(BUILD_ROOT)$(LIB_DIR)/
+       $(INSTALL) -m 755 $(LIB:%=lib/%) $(BUILD_ROOT)$(LIB_DIR)/
 
        $(INSTALL) -d $(BUILD_ROOT)$(docdir)/$(PACKAGE)-$(VERSION)/
        $(INSTALL) -m 644 doc/README \
Index: quilt.spec.in
===================================================================
RCS file: /cvsroot/quilt/quilt/quilt.spec.in,v
retrieving revision 1.16
diff -u -r1.16 quilt.spec.in
--- quilt.spec.in       15 Sep 2005 13:21:29 -0000      1.16
+++ quilt.spec.in       4 Nov 2005 15:24:34 -0000
@@ -30,8 +30,8 @@
 %setup
 
 %build
-./configure
-make prefix=/usr BUILD_ROOT=$RPM_BUILD_ROOT
+CFLAGS="$RPM_OPT_FLAGS" ./configure
+make prefix=/usr BUILD_ROOT=$RPM_BUILD_ROOT RELEASE=%release
 
 %install
 rm -rf $RPM_BUILD_ROOT


Thanks,
Andreas.