Re: [Quilt-dev] Time for 0.43?

[Randy.Dunlap]

On Tue, 27 Dec 2005, Jean Delvare wrote:

> Hi Randy,
>
> > > If anyone thinks anything else needs to be fixed before the next
> > > release, please speak up.
> >
> > I'd like to see a bit more support for the Linux kernel
> > canonical patch format.  It's documented in
> > linux/Documentation/SubmittingPatches (line 304 in 2.6.15-rc7).
> >
> > Basically this means (at least) keeping lines that contain
> > only "---" as a separator line before any diffstat output
> > or at the end of the "header".  It could (optionally ?)
> > additionally cause quilt to add From: and Signed-off-by:
> > template lines to the header.
>
> There have been proposals for header template support in the past, but
> they were not merged, probably due to a lack of time to review them and
> actually test and merge the code. Or maybe there was something wrong
> with them, I don't remember. Digging up the list archives may provide
> a couple patches for you to play with, and if any seems to work good
> enough for you, feel free to review it, polish it and submit it for
> inclusion again.

OK, I'll look into it.

> > A patch that keeps "---" lines in 'quilt refresh' is here:
> >   
> > http://developer.osdl.org/chrisw/quilt/quilt-refresh-linux-kernel-style.patch
> >
> > I don't know who wrote it.
>
> Well, I did :) And just as unsurprisingly, it is already merged in CVS:

Aha.  8)

> -------------------------------------------------------------------
> Tue Oct  4 18:43:42 CEST 2005 - address@hidden
>
> - scripts/patchfns.in: Prevent patch_header and patch_body from
>   mistakenly considering "---" alone on its header line as the
>   beginning of the patch body.
>
> -------------------------------------------------------------------
>
> This is one of the many reasons why I'd like to see the CVS version of
> quilt released as a new numbered version soon.

Yes.

-- 
~Randy