[Quilt-dev] Re: remove GNU date dependency

[Andreas Gruenbacher]

On Wednesday 01 February 2006 15:12, Gary V. Vaughan wrote:
> Tag!
>
> Andreas Gruenbacher wrote:
> > On Wednesday 01 February 2006 11:44, Gary V. Vaughan wrote:
> > > Apparently, perl doesn't use the native strftime... or at least on
> > > darwin %z works within perl, but isn't used in Apple's date
> > > implementation.
> >
> > Okay, that's good for us.
> >
> > > Here is a patch for a perl date wrapper (my first perl script!), I hope
> > > you can commit this in time for 0.43...  with it, I can `./configure
> > > --without-date' and have the testsuite complete successfully.
> >
> > Looks very nice. I have only a few comments:
> >
> >  * I don't see why we would need the pass_through option;
> >    we still fail further below, anyway.
>
> Needed because GetOptions treats `+' as an option delimitter (as in '+%s'),
> and otherwise fails with:
>
>   Unknown option: %

Ah, do you have the prefix_pattern config, as in the attached patch?


> >  * You ignore the result of GetOptions, which is only minor.
> >  * parse_utc_secs() shouldn't affect the --utc option. Also, the seconds
> >    since the epoch are always relative to UTC.
> >  * In scalar contect, @ARGV evaluates to $#ARGV + 1.
> >  * When you use sub foo() { ... } instead of sub foo { }, the
> >    parentheses declare "no parameters". It should be sub
> >    parse_utc_secs($) { ... } instead.
> >  * "use" inside a subroutine??
>
> Okay, thanks.  Not too many slip ups for my first script in perl ;-) *ahem*

No, it's really good.

> > Can you maybe give the checked-in version a quick check?
>
> With the attached small change, everything is good on darwin!

Does the attached proposal work equally well?

Andreas

prefix_pattern.diff
Description: Text Data