Re: [Quilt-dev] [PATCH] quilt mail: fix double closing angle bracket in message ID

[Andreas Gruenbacher]

On Thursday 02 August 2007 20:42, Paul Walmsley wrote:
> When 'quilt mail' is called with a --sender option that includes an
> E-mail address in angle brackets, quilt uses a double closing angle 
> bracket in the message ID.  Fix this by stripping the closing angle
> bracket out of $opt_sender first.

Thanks for the fix. I would prefer to detect angle brackets instead as in this 
patch:

Index: quilt.changes
===================================================================
RCS file: /sources/quilt/quilt/quilt.changes,v
retrieving revision 1.504
diff -u -r1.504 quilt.changes
--- quilt.changes       8 Aug 2007 10:20:52 -0000       1.504
+++ quilt.changes       8 Aug 2007 10:36:02 -0000
@@ -1,4 +1,11 @@
 -------------------------------------------------------------------
+Thu Aug  2 12:37:19 MDT 2007 - address@hidden
+
+- quilt mail: strip closing angle brackets from the mail sender
+  address before it is inserted into the message ID. (Changed
+  by address@hidden)
+
+-------------------------------------------------------------------
 Wed Aug  8 12:13:16 CEST 2007 - address@hidden
 
 - quilt setup: replace the --path argument with --sourcedir for
Index: quilt/mail.in
===================================================================
RCS file: /sources/quilt/quilt/quilt/mail.in,v
retrieving revision 1.29
diff -u -r1.29 mail.in
--- quilt/mail.in       6 May 2007 12:40:06 -0000       1.29
+++ quilt/mail.in       8 Aug 2007 10:36:02 -0000
@@ -68,7 +68,7 @@
 msgid()
 {
        local timestamp=$(date --utc "+%Y%m%d%H%M%S.%N")
-       echo "address@hidden@}"
+       echo "address@hidden"
 }
 
 process_mail()
@@ -88,7 +88,7 @@
                | sendmail ${QUILT_SENDMAIL_ARGS--f "$opt_sender"} "$@"
        else
                local from_date=$(date "+%a %b %e %H:%M:%S %Y")
-               echo "From $opt_sender $from_date"
+               echo "From $opt_sender_address $from_date"
                sed -e 's/^From />From /' $tmpfile
                echo
        fi
@@ -192,6 +192,7 @@
                ;;
        esac
 fi
+opt_sender_address=$(echo "$opt_sender" | sed -re 's:.*<([^<>]+)>.*:\1:')
 
 if [ -z "$opt_charset" ]; then
        case "${LC_ALL:-$ORIGINAL_LANG}" in


Okay?

Andreas