[Quilt-dev] Re: [PATCH] pager support like git

[Bert Wesarg]

Hi,

On Wed, Nov 18, 2009 at 18:55, Andreas Gruenbacher <address@hidden> wrote:
> On Wednesday 18 November 2009 18:51:29 Bert Wesarg wrote:
>> As a second proposal, we could pass the value of --color to the
>> setup_pager function and put the logic in there. This sounds actually
>> nicer, does it?
>
> No, because we might want to have color but no paging in some cases.
Actually, my first patch was correct. except that the
QUILT_PAGER_IN_USE was irrelevant.

That is because deciding whether we use color output or not does not
depend on the present of a to be running pager.

Sure, the condition '-t 1' is not true anymore if a pager is started,
but the pager can handle the color output well.

A first test with an unnamed pipe does not succeed on my site. I need
to reset the terminal after the script.

I would therefore suggest to reactivate the *_exit_handlers()
framework, to handle multiple EXIT traps.

Bert

>
> Andreas
>