[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Quilt-dev] filenames containing whitespace not handled correctly
From: |
Jean Delvare |
Subject: |
Re: [Quilt-dev] filenames containing whitespace not handled correctly |
Date: |
Fri, 27 Nov 2009 21:33:29 +0100 |
User-agent: |
KMail/1.9.1 |
Hi Yashi,
Le jeudi 5 novembre 2009 12:20, Yasushi SHOJI a écrit :
> Subject: [PATCH] add, files, remove: accept file name with spaces
>
> http://savannah.nongnu.org/bugs/?19477 and
> http://lists.nongnu.org/archive/html/quilt-dev/2009-09/msg00010.html
> reported that the current quilt does not work with file name with
> spaces. we all know that it is tough to handle it with bash script and
> fix all quilt commands.
>
> this patch only fixes add, files, and remove command with normal code
> path. no excessive test has been done but a few test code is also
> added. hope this starts fixing quilt to handle all possible path
> pattern.
> ---
> Hi Jean,
>
> At Thu, 29 Oct 2009 10:46:37 +0100,
> Jean Delvare wrote:
> >
> > Changing IFS and not restoring it afterwards looks wrong. Look at
> > annotate.in, there the value of IFS is carefully saved and restored.
>
> true. and thank you for reviewing my patch. I've reworked on IFS
> save/restore and here is the revised version. hope you like it.
Yes, this looks better. I have made minor changes to your patch and
committed it, thanks for your contribution :)
--
Jean Delvare
Suse L3