[Quilt-dev] Re: [PATCH] Remember location of patches and series file

[David Paleino]

Jean Delvare wrote:

> Hi David,

Hello,

> Le vendredi 4 décembre 2009 11:39, David Paleino a écrit :
>> > On Sun, 29 Nov 2009, Martin Panter wrote:
>> >> I've done this by allowing a local version of .pc/quiltrc. I'm
>> >> attaching two patches against quilt-0.48 that are related to this that
>> >> you can use if you want:
>> > 
>> > It's a possibility but not my preferred one because someone still has
>> > to setup the quiltrc file manually.
>> 
>> And, besides that, quilt documentation says that all it's needed to share
>> patches is QUILT_PATCHES (specifically, the series file and the patches).
>> Requiring the user to change things in .pc/ would break this
>> "portability".
>> 
>> (cfr. quilt.pdf, §5.3)
> 
> I don't quite follow you here.
> 
> For one thing, the statement that sharing $QUILT_PATCHES is sufficient
> isn't true even today. quilt supports series files both in
> $QUILT_PATCHES and at the root of the source tree. In the latter case,
> obviously, sharing $QUILT_PATCHES is not sufficient.

You skipped my parenthesis, eh :)
"specifically, the series file and the patches" -- so my statement still 
holds.

> For another, I fail to see how .pc/quiltrc would alter the current
> situation. The fact that QUILT_PATCHES could be redefined there does
> not change the fact that the contents of $QUILT_PATCHES is what you
> want to share (modulo the exception mentioned above.)

If you only share $QUILT_PATCHES (modulo the exception above), you're not 
giving some additional information needed to apply the patches -- i.e. 
QUILT_PATCHES itself. (but that could be any QUILT_* variable)

On the other hand, what would be the drawbacks of having yet-another-
special-file (like "series"), called "quiltrc" (or ".quiltrc"), to be looked 
in $QUILT_PATCHES/quiltrc, ./quiltrc and the like?
This way one could specify per-project quilt variables, and keep them also 
in a $VCS (while .pc could not, since it's meant as a temporary directory, 
or at least that's how I understood it).
Did I miss something?

> Lastly, quilt.pdf is a piece of documentation, not a specification.

Ack :)

Thank you for replying,
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174