Re: [Quilt-dev] push -f fails on empty patch

[Jean Delvare]

Le vendredi 23 novembre 2012 à 13:40 +0100, Andreas Grünbacher a écrit :
> 2012/11/23 Jean Delvare <address@hidden>
> >
> > Hi Andreas,
> >
> > I noticed that "quilt push -f" fails on patch files which have a header
> > but no actual contents. This is because "patch" complains that it only
> > found garbage in the patch, and returns with status 2. "quilt push" only
> > honors option "-f" if patch returns with status 1.
> 
> Patch fails if the patch file isn't completely empty, but with
> only a header, it obviously isn't.

Correct. A totally empty file "works", but one with a header comment or
even just a diffstat section fails.

> > This change came with commit 031ed720 in the middle of other, apparently
> > unrelated changes. All the commit message says is: "Fail pushes when GNU
> > patch exits with a status > 1." But it doesn't say _why_ that change was
> > made.
> 
> I don't remember. If the other commits around this commit don't show
> why, it probably wasn't critical.

I couldn't find anything explaining the change in the surrounding
commits, no. So I'll just revert it for now.

Thanks for the quick reply.

-- 
Jean Delvare
Suse L3