[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Quilt-dev] [patch 6/7] Exit with an error when diffs retcode=2 (err
From: |
Martin Quinson |
Subject: |
Re: [Quilt-dev] [patch 6/7] Exit with an error when diffs retcode=2 (error) on patch |
Date: |
Sat, 18 Jan 2014 01:38:18 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hello,
On Fri, Jan 17, 2014 at 10:11:47PM +0100, Jean Delvare wrote:
>
> Hmm. We incorrectly assumed that portability of this construct wasn't an
> issue because we were using bash. We aren't. The tester is written in
> perl, and except for a few special cases, it blindly execs the commands
> in the test cases. So we get /usr/bin/printf called here, not bash's
> printf.
>
> I am using GNU coreutils 8.12 and 8.21 on my machine. I suppose you are
> using something else on your system.
Nope, I'm the same. But /bin/sh is an alias to dash here. That might
be why, as the runner script seems to use /bin/sh to start the
commands that need a shell (such as the ones with a redirection).
> $ bash -c "printf '\\x02\\x00\\x01'" > test.bin
>
> Performance-wise it's suboptimal but I suppose we don't really care.
I did that, and it works. Yeah, the performance drop is not noticable
on this test file ;)
The new patch should be ready now. Stay tuned.
Bye, Mt.
--
C combines the power of assembler with the portability of assembler.