[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Quilt-dev] [patch 5/5] Informative message when using graph without
|
From: |
Jean Delvare |
|
Subject: |
Re: [Quilt-dev] [patch 5/5] Informative message when using graph without graphviz |
|
Date: |
Mon, 09 Jun 2014 14:38:42 +0200 |
Le Monday 09 June 2014 à 14:24 +0200, Jean Delvare a écrit :
> Hi Martin,
>
> Le Friday 09 May 2014 à 00:13 +0200, Martin Quinson a écrit :
> > in attachment, a new version of this patch taking your remarks into
> > account.
>
> Looks good, except that you don't need to add dots at the end of error
> messages, what you need to add is \n, otherwise the error message and
> shell prompt get mixed.
>
> I have a similar patch adding a check for rpmbuild in the "setup"
> command. I think it may make sense to add a small helper function to
> handle these checks in a unified way.
I fixed that and committed both patches.
--
Jean Delvare
SUSE L3 Support