Re: [Quilt-dev] [PATCH 2/2 RFC] setup: Add --fast option

[Jean Delvare]

Le Tuesday 18 November 2014 à 11:51 +0100, Jean Delvare a écrit :
> This is an alternative implementation of "quilt setup" for rpm spec
> files, which is much faster than the original implementation. The
> idea is to have rpmbuild generate our working tree directly, instead
> of taking note of everything it does and then replaying that record
> from scratch.
> 
> In general, the generated working tree should be the same with and
> without --fast.  There are 3 known exceptions though:
> * The header of the series files is incomplete when using --fast,
>   which means that you can't reuse these series files to feed "quilt
>   setup" later.
> * If the spec file generates files other than with the tar, unzip and
>   patch commands, you wouldn't get these files in your working tree
>   before, but now with --fast you will.
> * With --fast, all patches are added to the series file, regardless
>   of whether they apply or not. This also means that patches which
>   fail to apply are not reported as such until you attempt to push
>   them.
> 
> On large packages, this alternative implementation was found to be
> up to 4 times faster than the original implementation.
> ---
> This is my SUSE hackweek 11 project, more information at:
> https://hackweek.suse.com/11/projects/194
> 
> Note that this is only a RFC, I do not intend to commit this right now
> as I first want to investigate ways to minimize the differences between
> legacy mode and fast mode code paths in order to reduce the complexity
> and code redundancy.
> 
>  Makefile.in                           |    6 
>  quilt/scripts/inspect-wrapper-fast.in |  208 
> ++++++++++++++++++++++++++++++++++
>  quilt/scripts/inspect.in              |   38 ++++--
>  quilt/setup.in                        |   31 ++++-
>  4 files changed, 267 insertions(+), 16 deletions(-)

Note that I have found a less intrusive way to achieve the same so I
will not commit this patch. I'll post the replacement one when it's
ready.

-- 
Jean Delvare
SUSE L3 Support