[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Quilt-dev] [PATCH] Test refresh behavior on hard-linked patches
|
From: |
Jason Wessel |
|
Subject: |
Re: [Quilt-dev] [PATCH] Test refresh behavior on hard-linked patches |
|
Date: |
Mon, 12 Jan 2015 14:16:00 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 01/12/2015 07:11 AM, Jean Delvare wrote:
> If a patch file has hard links, refreshing it should break the links
> so that the other copies are left unmodified. Test this behavior to
> avoid breaking it accidentally.
> ---
> Jason, I'm afraid your patch breaks this test case. I think that the
> following test:
>
> [ -L "$filename" -a "$QUILT_NO_RM_SYMLINKS" != "yes" ]
>
> should instead read:
>
> [ ! -L "$filename" -o "$QUILT_NO_RM_SYMLINKS" != "yes" ]
I would agree. I tried your new test, with the v2 version and all is
well.
I am not one to argue in the value of regression testing, and now
we'll have a test hardlinks and symlinks. :-)
Cheers,
Jason.