[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Quilt-dev] [RFC PATCH] quilt-el: fix quilt-editable when patches ar
From: |
Jean Delvare |
Subject: |
Re: [Quilt-dev] [RFC PATCH] quilt-el: fix quilt-editable when patches are stored in subdirs |
Date: |
Tue, 10 Mar 2015 21:03:07 +0100 |
Le Tuesday 10 March 2015 à 15:40 +0100, Cédric Le Goater a écrit :
> From: Cédric Le Goater <address@hidden>
>
> I frequently use sub-directories to store different patchsets under
> the quilt patches/ directory. Unfortunately, the quilt emacs mode
> does not handle this case and the file is not considered editable.
>
> The issue seems to be in the quilt-top-patch which does an equivalent
> of basename on the patch name. The proposal below changes the
> quilt-editable routine to keep the full name of the patch.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
> ---
> lib/quilt.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I don't use emacs so I can't really comment on or test that. Leonid,
Satoru, can either of you please review and test this patch? Thanks.
> Index: quilt.git/lib/quilt.el
> ===================================================================
> --- quilt.git.orig/lib/quilt.el
> +++ quilt.git/lib/quilt.el
> @@ -175,7 +175,7 @@
> (if (quilt-bottom-p)
> (quilt-cmd "applied") ; to print error message
> (setq dirs (if quilt-edit-top-only
> - (list (quilt-top-patch))
> + (list (substring (quilt-cmd-to-string "top") 0 -1))
> (cdr (cdr (directory-files (concat qd ".pc/"))))))
> (while (and (not result) dirs)
> (if (file-exists-p (concat qd ".pc/" (car dirs) "/" fn))
>
--
Jean Delvare
SUSE L3 Support