[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Quilt-dev] [patch] verbose error message when the serie file does n
From: |
Jean Delvare |
Subject: |
Re: [Quilt-dev] [patch] verbose error message when the serie file does not exist |
Date: |
Tue, 24 Mar 2020 12:40:36 +0100 |
On Tue, 2020-03-24 at 11:08 +0100, Jean Delvare wrote:
> I just pushed a new test case to cover this situation, so we won't
> introduce that kind of regression.
By the way, this test case revealed a few inconsistencies. While most
commands properly report "No series file found" if you are not in a
quilt-managed tree, 3 commands diverge from this behavior:
* "quilt pop" reports "No patch removed" instead, which while not
incorrect, is not consistent.
* "quilt series" report nothing. That's what Martin's patch aimed at
fixing. I wonder it should report "No series file found" even when not
in verbose mode? That would seem more consistent.
* "quilt snapshot" creates a .pc/ subdirectory and an empty .snap/
directory there. Again while not fundamentally wrong, it doesn't seem
particularly useful in the absence of a series file.
I'll look into fixing "pop" and "snapshot" to behave the same as all
other commands.
--
Jean Delvare
SUSE L3 Support