[Rdiff-backup-bugs] [bug #23994] Crash when backing up an ext3 folder to fat32

[Andrew Ferguson]

Follow-up Comment #3, bug #23994 (project rdiff-backup):

Actually, that previous comment was from 2.6.25.

But this one is from 2.6.26:

commit 2d518f84e5ecd1d71df0e6ac5176d212f68c27ce
Author: OGAWA Hirofumi <address@hidden>
Date:   Thu Jun 12 15:21:28 2008 -0700

    fat: relax the permission check of fat_setattr()
    
    New chmod() allows only acceptable permission, and if not acceptable, it
    returns -EPERM.  Old one allows even if it can't store permission to on
    disk inode.  But it seems too strict for users.
    
    E.g.  https://bugzilla.redhat.com/show_bug.cgi?id=449080: With new one,
    rsync couldn't create the temporary file.
    
    So, this patch allows like old one, but now it doesn't change the
    permission if it can't store, and it returns 0.
    
    Also, this patch fixes missing check.
    
    Signed-off-by: OGAWA Hirofumi <address@hidden>
    Signed-off-by: Andrew Morton <address@hidden>
    Signed-off-by: Linus Torvalds <address@hidden>

commit e97e8de388723f9491514fa0434ddf1fd713a188
Author: OGAWA Hirofumi <address@hidden>
Date:   Mon Apr 28 02:16:26 2008 -0700

    fat: fat_setattr() fix
    
    Fix fat_setattr() on the case of showexec option. If user specified
    showexec option, inode->i_mode may not have S_IXUGO. This just use
    inode->i_mode to fix it.
    
    And with this patch, we don't allow chmod() on memory inode, it's just
    bad behaviour. IOW, we allow changing S_IWUGO only which can be stored
    to disk.
    
    Signed-off-by: OGAWA Hirofumi <address@hidden>
    Signed-off-by: Andrew Morton <address@hidden>
    Signed-off-by: Linus Torvalds <address@hidden>


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?23994>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/