Re: [screen-devel] fix build failure on MacOS X

[Micah Cowan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Christian Ebert wrote:
> * Micah Cowan on Thursday, August 07, 2008 at 12:07:46 -0700
>> Christian Ebert wrote:
>>> Latest git source fail to compile here (MacOS 10.4.11).
> 
> oops, I should have shown how it chokes:
> 
> $ make
> CPP="gcc -E -g -O2 -I/usr/local/include -I/sw/include" srcdir=. sh ./osdef.sh
> AWK=gawk CC="gcc -g -O2 -I/usr/local/include -I/sw/include" srcdir=. sh 
> ./comm.sh
> gcc -c -I. -I.    -g -O2 -I/usr/local/include -I/sw/include screen.c
> In file included from screen.c:51:
> config.h:569: error: parse error before ‘/’ token
> In file included from /usr/include/locale.h:40,
>                  from screen.c:75:
> /usr/include/_locale.h:68: error: parse error before ‘}’ token
> make: *** [screen.o] Error 1
> 
>>> diff -r 186c11906163 src/acconfig.h
>>> --- a/src/acconfig.h        Thu Aug 07 02:34:28 2008 -0700
>>> +++ b/src/acconfig.h        Thu Aug 07 15:16:43 2008 +0200
>>> @@ -564,7 +564,6 @@
>>>  * If you are on a SYS V machine that restricts filename length to 14 
>>>  * characters, you may need to enforce that by setting NAME_MAX to 14
>>>  */
>>> -#undef NAME_MAX            /* KEEP_UNDEF_HERE override system value */
>>> #undef NAME_MAX
>>>
>>> /*
>> Hm. Strange that it didn't affect you before, when it was present in
>> config.h.in (acconfig.h was simply "git mv"ed from config.h.in).
> 
> Yes. Strange.

Or perhaps not so very strange: the culprit appears to be a behavioral
change (bug) in autoconf-2.62 (not present in 2.61):

  http://bugs.gentoo.org/217311

Thanks to Emanuele Giaquinta for pointing that out on IRC.

- --
Micah J. Cowan
Programmer, musician, typesetting enthusiast, gamer.
GNU Maintainer: wget, screen, teseq
http://micah.cowan.name/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIm5bU7M8hyUobTrERApeMAJ9koYXAbl7zhsd0uG3eGge0McY8WQCfRmph
H2cTI6zRcFThkvAjoSNRNeU=
=uAx7
-----END PGP SIGNATURE-----