[screen-devel] [PATCH for master] Fix screen leaving zombie processes

[Amadeusz Sławiński]

When window dies we should wait for child process to die, otherwise
there is no one to reap it.

So emove WNOHANG in waitpid(), which may cause screen to not wait for
child to die and kill window, leaving zombie process.

Bug: 25089

Signed-off-by: Amadeusz Sławiński <address@hidden>
---
 src/window.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/window.c b/src/window.c
index 48fa6a27..f438ad6a 100644
--- a/src/window.c
+++ b/src/window.c
@@ -1896,7 +1896,7 @@ void WindowDied(Window *p, int wstat, int wstat_valid)
        if (!wstat_valid && p->w_pid > 0) {
                /* EOF on file descriptor. The process is probably also dead.
                 * try a waitpid */
-               if (waitpid(p->w_pid, &wstat, WNOHANG | WUNTRACED) == p->w_pid) 
{
+               if (waitpid(p->w_pid, &wstat, WUNTRACED) == p->w_pid) {
                        p->w_pid = 0;
                        wstat_valid = 1;
                }
-- 
2.23.0