[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/1] Gemtext reader for Skribilo
|
From: |
Ludovic Courtès |
|
Subject: |
Re: [PATCH 0/1] Gemtext reader for Skribilo |
|
Date: |
Thu, 17 Mar 2022 11:17:44 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello!
Arun Isaac <arunisaac@systemreboot.net> skribis:
> I wrote a Gemtext reader for Skribilo. I'll use it for a week and push
> it if there are no bugs. Any feedback would be welcome too!
Very nice!
> In `define-reader', I have no idea why need to specify a version
> number. But, I set a version number of 0.1 just like outline mode.
Yeah, I think that was probably overengineered a little bit. :-)
> * src/guile/skribilo/reader/gemtext.scm: New file.
> * src/guile/Makefile.am (readers): Register it.
> * doc/user/syntax.skb (The Gemtext Syntax): New section.
Could you add unit tests under ‘tests/readers’?
That directory is, ahem, sparsely populated right now, but I think we’ll
be grateful down the road to have that safety net for the Gemtext
reader.
Apart from that it looks great to me!
Thanks,
Ludo’.