Re: [Sks-devel] [PATCH] auto-refresh membership DNS

[Phil Pennock]

On 2009-03-22 at 12:47 +0000, Kim Minh Kaplan wrote:
> Phil Pennock:
> 
> > Previously, membership was only automatically reloaded in the db server,
> > not the recon server.
> 
> Why do you say this?  Reading Membership.get and Membership.test, the
> file is reloaded whenever it is modified.  thus this patch seems wrong.

sks.pod:
----------------------------8< cut here >8------------------------------
=item -membership_reload_interval

Maximum interval (in hours) at which membership file is reloaded.
----------------------------8< cut here >8------------------------------

There are supposed to be *two* triggers for reload -- one is mtime
change, one is -membership_reload_interval expiring.  This works in the
dbserver, not in the reconserver.  Ironic.

Thus I stand by the intent of my patches.

With this fixed, people who change DNS won't have to post to lists
asking people to touch their membership files to pick up the DNS change,
and I will be able to get rid of my cron job which touches the
membership file, as sks will do The Right Thing.

The additional load is an extra couple of DNS lookups per peer, every
reload interval; it's a float, but I doubt many people set this to less
than 1, so it's pretty light.

-Phil

pgp6KqEb0NASk.pgp
Description: PGP signature