[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Solang-devel] [PATCH] Search infrastructure
From: |
Debarshi Ray |
Subject: |
Re: [Solang-devel] [PATCH] Search infrastructure |
Date: |
Thu, 21 May 2009 17:03:59 +0530 |
Looks fine to me.
A query with (-1, 10, -1) would not fetch all October pictures for any
year and day. That is fine, I guess.
A few nitpicks:
----
>From e4919de8b120ee77e26d8d79febe3ac40666b285 Mon Sep 17 00:00:00 2001
From: Santanu Sinha <address@hidden>
Date: Thu, 21 May 2009 16:00:56 +0530
Subject: [PATCH 4/4] Support for Date Wise Photo count generation
A new class DatePhotoInfo was added. A list of this type of objects
is returned by the Engine if required. The query canbe filtered using
the paramters of this function.
----
It should be "can be" not "canbe".
----
diff --git a/src/attribute/date-photo-info.cpp
b/src/attribute/date-photo-info.cpp
new file mode 100644
index 0000000..531ac23
--- /dev/null
+++ b/src/attribute/date-photo-info.cpp
+ [...]
+void
+DatePhotoInfo::set_count(gint count) throw()
+{
+ count_ = count;
+}
+
+}
----
There will be a "// namespace Solang".
----
diff --git a/src/attribute/date-photo-info.h b/src/attribute/date-photo-info.h
new file mode 100644
index 0000000..3c6110a
--- /dev/null
+++ b/src/attribute/date-photo-info.h
@@ -0,0 +1,41 @@
+#ifndef SOLANG_DATE_PHOTO_INFO_H
+#define SOLANG_DATE_PHOTO_INFO_H
+
+#include "modification-date.h"
+
+namespace Solang
+{
+
+class DatePhotoInfo
+{
+ public:
+ DatePhotoInfo();
+ DatePhotoInfo( const ModificationDate &, gint);
+ DatePhotoInfo( const DatePhotoInfo & );
+ ~DatePhotoInfo();
----
Tabbed indentation in parametrized constructor.
----
diff --git a/src/common/types.h b/src/common/types.h
index 5750ab4..082a9bd 100644
--- a/src/common/types.h
+++ b/src/common/types.h
@@ -68,6 +68,9 @@ class IPlugin;
typedef std::tr1::shared_ptr<const IPlugin> ConstIPluginPtr;
typedef std::tr1::shared_ptr<IPlugin> IPluginPtr;
+class DatePhotoInfo;
+typedef std::list<DatePhotoInfo> DatePhotoInfoList;
+
class Photo;
typedef std::tr1::shared_ptr<const Photo> ConstPhotoPtr;
typedef std::tr1::shared_ptr<Photo> PhotoPtr;
diff --git a/src/database/database.cpp b/src/database/database.cpp
index 121c094..27d5f41 100644
--- a/src/database/database.cpp
+++ b/src/database/database.cpp
@@ -26,6 +26,7 @@
#include "db-table-factory.h"
#include "progress-observer.h"
#include "thumbnail.h"
+#include "date-photo-info.h"
----
You could add it in alphabetical order as you did in the Makefile.ams.
You can 'git reset --soft HEAD^', commit as before and push.
Happy hacking,
Rishi
--
One reason that life is complex is that it has a real part and an
imaginary part.
-- Andrew Koenig
- [Solang-devel] [PATCH] Search infrastructure, Santanu Sinha, 2009/05/21
- Re: [Solang-devel] [PATCH] Search infrastructure,
Debarshi Ray <=
- Re: [Solang-devel] [PATCH] Search infrastructure, Debarshi Ray, 2009/05/21
- Re: [Solang-devel] [PATCH] Search infrastructure, Santanu Sinha, 2009/05/22
- Re: [Solang-devel] [PATCH] Search infrastructure, Debarshi Ray, 2009/05/22
- Message not available
- Re: [Solang-devel] [PATCH] Search infrastructure, Debarshi Ray, 2009/05/23
- Re: [Solang-devel] [PATCH] Search infrastructure, Santanu Sinha, 2009/05/23
- Re: [Solang-devel] [PATCH] Search infrastructure, Debarshi Ray, 2009/05/23
- Re: [Solang-devel] [PATCH] Search infrastructure, Debarshi Ray, 2009/05/23