solang-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Solang-devel] [PATCH] Enlarged and slideshow renderer improvements


From: Debarshi Ray
Subject: [Solang-devel] [PATCH] Enlarged and slideshow renderer improvements
Date: Tue, 29 Sep 2009 14:23:28 +0300

(This looks big, but basically just moves some code from the
constructors and init methods to other methods which are invoked later
in the lifetime of the renderers)

http://rishi.fedorapeople.org/0001-Enlarged-and-slideshow-renderer-improvements.patch

Dock the EnlargedRenderer::dockItem_ only when IRenderer::present is
called for the first time. We can thus assign the page number to
EnlargedRenderer::pageNum_ and connect to
MainWindow::get_notebook_center()->signal_switch_page
without using Application::init_end. The following methods were added
to MainWindow to facilitate this:
    + MainWindow::dock_object_center
    + MainWindow::undock_object_center

Create and populate the Gtk::ActionGroups only when the renderer is
presented the first time. Free them up when they are finalized. Ditto
for the other signals and GdlDockItems.

To present either of these renderers IRenderer::present should be
invoked before IRenderer::render. The first call to IRenderer::present
will perform the aforementioned tasks without which IRenderer::render
will fail.

Happy hacking,
Debarshi
-- 
One reason that life is complex is that it has a real part and an
imaginary part.
    -- Andrew Koenig




reply via email to

[Prev in Thread] Current Thread [Next in Thread]