[PATCH 1/1] add --with-audio-output-method=<name> option

[Bohdan R . Rau]

On Thu, 02 Dec 2010 21:08:16 +0000, Andrei.Kholodnyi at gmail.com wrote:
> On Dec 2, 2010 4:24pm, "Bohdan R. Rau" <ethanak at polip.com> wrote:

>> BTW don't you think it would be simpler (especially for maintenance)
with
>> #ifdef? I personally don't think the configure script should know too
>> much
>> about C code...
> 
> It is not about a C code IMO, it is just about a proper configuration.
> and autotools are exactly for this purpose.

Yes, autotools should give proper configuration to code. Question: what is
"proper configuration"?

For me it means:

1) "user set manually default audio output method as 'xxx'" (in fact,
there should be some test, to prevent user setting names from Neverland).
or:
2) "we have only one method called 'xxx'"
or:
3) "we have 'xxx', 'yyy' and 'zzz' methods, select one yourself.

I think in case when we have more than one method, selection should be
done on program level, not configuration.

Additionally - maintainer of C code may be not the same as maintainer of
autotools script, and what do uou think, who knows better?

BTW - your patch seems to work perfectly (I applied it today and I'm very
glad), and at now we don't need any changes. But the situation may change
in future...

ethanak
-- 
http://milena.polip.com/ - Pa pa, Ivonko!