[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/3] Remove references to TEMP_FAILURE_RETRY
From: |
Trevor Saunders |
Subject: |
[PATCH 1/3] Remove references to TEMP_FAILURE_RETRY |
Date: |
Wed, 25 Jul 2012 10:12:46 -0400 |
> +ssize_t
> +safe_read(int fd, void *buf, size_t count) {
nit, { on its own line plx
Also it would be great if you put these in a common header somewhere and
used them everywhere we have TEMP_FAILURE_RETRY currently. I'm fairly
confident the function is small enough its worth just defining it in the
header as static, and maybe inline, but I forget if c89 has inline or
not, and speechd seems to be c89 currently :/
> +ssize_t
> +safe_write(int fd, const void *buf, size_t count) {
same here :)
> --- a/src/server/output.h
> +++ b/src/server/output.h
> @@ -1,7 +1,7 @@
> +/* Utility functions */
> +ssize_t safe_read(int fd, void *buf, size_t count);
> +ssize_t safe_write(int fd, const void *buf, size_t count);
oh, so you did put them in a header, but not at all the header someone
looking for them would e xpect, might be ok if someone cleans it up
later, on the other hand that could be said of a lot of our code.
Trev
[PATCH 1/3] Remove references to TEMP_FAILURE_RETRY,
Trevor Saunders <=
[PATCH v2 0/3] Portability improvements, Boris Dušek, 2012/07/29