[PATCH 0/8] Hussain Jasim's pitch range feature addition.

[Luke Yelavich]

On Sat, Oct 25, 2014 at 04:44:01PM EDT, Trevor Saunders wrote:
> On Fri, Oct 24, 2014 at 02:44:37PM -0400, Luke Yelavich wrote:
> > I've just finished hand editing Hussain Jasim's patches from his git repo, 
> > found at git://github.com/ringulreith/speechd.git. The code builds at 
> > least, although I have not yet tested it.
> > 
> > In hand-editing these, it is possible I dropped a hunk that I shouldn't 
> > have, and likely I left a hunk in that was an accidental reversion that I 
> > meant to remove. If folks could please have a look, that would be much 
> > appreciated. I am posting these patches to the list so they can get a 
> > proper review.
> 
> I took a quick look at the more significant patches and they seemed
> reasonable though not particularly fun reading.

Thanks, much appreciated.

> My only issue is that I'm not sure it makes sense to add support to
> change settings in config files.  I know its been done for settings
> previously, but I'm of the opinion we should remove that support.  We
> should pick reasonable built in defaults and then allow clients to
> handle changing from that.
>  
> > I am not entirely sure if this is something we should include, see another 
> > incoming reply from me to the original pull request, but its worth 
> > considering nonetheless.
> 
> People want this right? what exactly is your alternative?

None, but I guess it ties in with providing module specific settings to clients 
if desired as per the other thread.

> I'd rather see modules able to expose arbitrary settings to clients, but
> I'm not sure I think its reasonable to make someone implement that to
> get this feature.

Fair enough. I'll apply these patches, and we can go onto improving things from 
there.

Luke