Re: [STUMP] A patch

[Manuel Giraud]

Shawn Betts <address@hidden> writes:

> But admittedly that's duplicate code which is bad. What we REALLY need
> is just a format string..which I'm in the process of adding :).

Ok.

>> diff -u -r1.21 stumpwm.lisp
>> --- stumpwm.lisp     12 Nov 2004 06:35:47 -0000      1.21
>> +++ stumpwm.lisp     15 Nov 2004 16:26:54 -0000
>> @@ -100,6 +100,10 @@
>>    ;; In the event of an error, we always need to close the display
>>    (unwind-protect
>>        (progn
>> +    ;; Load rc file
>> +    (multiple-value-bind (success err rc) (load-rc-file)
>> +      (unless success
>> +        (format t "Error loading ~A: ~A" rc err)))
>>      ;; Initialize all the screens
>>      (handler-case
>>       (setf *screen-list* (mapcar #'init-screen (xlib:display-roots 
>> *display*)))
>> @@ -114,10 +118,6 @@
>>      ;; Setup our keys. FIXME: should this be in the hook?
>>      (set-default-bindings)
>>      (echo-string (first *screen-list*) "Welcome to The Stump Window 
>> Manager!")
>> -    (multiple-value-bind (success err rc) (load-rc-file)
>> -      (unless success
>> -        (echo-string (first *screen-list*)
>> -                     (format "Error loading ~A: ~A" rc err))))
>>      (run-hook *start-hook*)
>>      ;; Let's manage.
>>      (stumpwm-internal-loop))
>
> I'm curious about this change. Why did you make this change?

If you change the input window font in your .stumpwmrc file it will not
be effective because the #'init-screen stuff is done before.

> I'm puzzled by this hunk too. Why have a run-command-string when you
> can run it through /bin/sh and have all the niceness it provides?
>
> Also, you should be able to put these commands in your .stumpwmrc (Not
> that I don't appreciate the patch).

Maybe your are right here. But i think that #'partial-command can be
useful.

> Where are you getting the split-sequence package from?

It is an external "standard" package (see: Cliki) ... but it should
appear in the asd and yes it is another external dependance (but it
avoid wheel reinvention).

> I put your sample rc file in CVS. Thanks! I've also added you to the
> AUTHORS file.

Thanks :)

-- 
Manuel Giraud (CNRS/CETP)