Re: [STUMP] [PATCH] Confirmation when gkill is called interactively, fixed a bug in kill-group

[Shawn Betts]

On Sat, May 24, 2008 at 10:37 AM, Lionel Flandrin
<address@hidden> wrote:
> * Ask for confirmation when gkill is called interactively in a
>  non-empty group.
> * kill-group now checks the "to-group" is not the same as the group to
>  be deleted. Checking if the total number of groups is > 1 is not
>  enough since the other groups can be hidden, and in this case
>  next-group == current-group. This caused the windows to be sent to a
>  deleted group, never to be found again...
> * New function "ask-confirmation" that prints a message and returns T
>  if the user press 'y', NIL otherwise.

This is a great patch but I can't accept it because it relies on the
interactive patch which I believe is not good enough. I'd love to
apply the other parts if you could supply them in a new patch. I like
the idea of having an confirmation message, but the trick is to do it
right which appears to be Hard.

-Shawn