[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [STUMP] [PATCH] adjoin instead of push for adding to *screen-mode-li
|
From: |
Shawn |
|
Subject: |
Re: [STUMP] [PATCH] adjoin instead of push for adding to *screen-mode-line-formatters* |
|
Date: |
Thu, 10 Jul 2008 19:56:58 -0700 |
|
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) |
John Li <address@hidden> writes:
> On Mon, Jul 07, 2008 at 02:53:59PM +0200, Julian Stecklina wrote:
>> John Li <address@hidden> writes:
>>
>> > - (setq *bat-state* nil)
>> > + (setf *bat-state* nil)
>> [...]
>> > - (setq *bat-remain-time* (multiple-value-bind (h m)
>> > + (setf *bat-remain-time* (multiple-value-bind (h m)
>>
>> Why did you change SETQ to SETF?
>
> Because Shawn likes it that way.
Most importantly, I like it for a good reason. (setf symbol value)
expands to (setq symbol value) so given than setf handles this and
many other forms, go for consistency and always use setf. For this
reason, using setq is bad style.
-Shawn