[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [STUMP] [PATCH] Renumbering of groups
From: |
Nils Anspach |
Subject: |
Re: [STUMP] [PATCH] Renumbering of groups |
Date: |
Thu, 2 Dec 2010 02:26:59 +0100 |
Manuel Giraud schrieb am 01.12.2010 um 10:39:32 +0100:
> Nils Anspach <address@hidden> writes:
>
> > Hello list,
> >
> > the following patches (against HEAD) add functions for altering the
> > current numbering of groups.
>
> I've tested it and it works ok.
>
> > [...]
> > + (if (find-group (group-screen group) new-num)
> > + (message "^1*^BError: Number already in use.")
>
> Maybe here you could use swap-group-numbers instead of sending an error:
> it would be more consistant with the 'number' command that does this for
> window (or maybe it is not a desired behaviour).
I think this is mainly a matter of taste. I personally prefer the current
implementation because it prevents me from accidentally changing my
set up groups order, and I you have several groups this might easily
happen.
Nils