Re: [STUMP] [PATCH] Do not give focus to unfocusable windows

[Ben Spencer]

On Sat, Jul 23, 2011 at 09:16:03AM -0400, Max Mikhanosha wrote:
> Currently in floating groups StumpWM raises and gives focus to newly
> mapped windows unconditionally, whenever they want it or not.
> 
> This results in user's typing being interrupted by notification
> windows, such as xfce-notifyd window when amarok plays new song (or
> any other dbus notifacitons)
> 
> Attached is a patch that stops StumpWM from giving focus in floating
> groups to windows that have AcceptInput hint set to :off. It just raises the 
> window
> but does not give it focus. It does not change any processing for tile 
> groups..

Hi Max,

This looks useful.  I wonder whether it's actually worthwhile caching
the wm hints though, given that in many cases we will be dealing with
a newly-mapped window and thus have to fetch the hints at that point
anyway.

Additionally, it would be nice to put the duplicated focus/raise code
into its own function, say float-focus-or-raise.

Thanks, Ben