[Synaptic-devel] RGWindow::RGWindow() may g_free() an unallocated pointer

[Anthony Fok]

Hello,

While synaptic-0.31+cvs20030120, compiled with g++-2.95, worked very
nicely on Debian, it crashed right away when I tried to "Update List"
or config the repository, for example, when I compiled it on Thiz Linux
with g++-3.2.

It seems that it is in RGWindow::RGWindow() in gtk/rgwindow.cc, when
useGlade is false, gchar* filename never got assigned, and was
nevertheless g_free(filename) in the end.  I guess g++-3.2 (or perhaps
with certain optimization) that gchar* filename wasn't assigned NULL to
it.  The attach patch attempts to fix this.  It works here.  :-)

Cheers,

Anthony

-- 
Anthony Fok Tung-Ling
ThizLinux Laboratory   <address@hidden> http://www.thizlinux.com/
Debian Chinese Project <address@hidden>       http://www.debian.org/intl/zh/
Come visit Our Lady of Victory Camp!           http://www.olvc.ab.ca/

synaptic-0.31+cvs20030120-free.patch
Description: Text document