[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [sysvinit] Incorrect handling of UTF-8 in 2.88dsf-1?
From: |
Dr. Werner Fink |
Subject: |
Re: [sysvinit] Incorrect handling of UTF-8 in 2.88dsf-1? |
Date: |
Mon, 26 Apr 2010 17:46:11 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Fri, Apr 23, 2010 at 10:23:41PM +0200, Petter Reinholdtsen wrote:
> I've been going throught the Debian patches and dropping the ones
> currently included in version 2.88dsf-1. This patch seemed to be
> applied, but it seem to be applied wrong:
>
> Purpose: Make sure the utf-8 flag is not cleared from the tty.
> Authour: Samuel Thibault
> Fixes: #547073
>
> --- trunk.orig/src/init.c 2009-10-25 15:29:44.000000000 +0100
> +++ trunk/src/init.c 2009-10-25 15:30:30.000000000 +0100
> @@ -721,7 +721,11 @@
> /*
> * Set pre and post processing
> */
> - tty.c_iflag = IGNPAR|ICRNL|IXON|IXANY;
> + tty.c_iflag = IGNPAR|ICRNL|IXON|IXANY
> +#ifdef IUTF8 /* Not defined on FreeBSD */
> + | (tty.c_iflag & IUTF8)
> +#endif /* IUTF8 */
> + ;
> tty.c_oflag = OPOST|ONLCR;
> tty.c_lflag = ISIG|ICANON|ECHO|ECHOCTL|ECHOPRT|ECHOKE;
>
>
> The code in question now look like this:
>
> tty.c_iflag = IGNPAR|ICRNL|IXON|IXANY;
> #ifdef IUTF8 /* Not defined on FreeBSD */
> tty.c_iflag |= IUTF8;
> #endif /* IUTF8 */
>
> As far as I can tell, this do not work, as it will not pass on the
> existing setting of the IUTF8 bit, but instead always set it if IUTF8
> is defined.
>
> Werner, you applied it. Do I misunderstand something?
Oops ... yes indeed this may not work on a serial terminal.
Werner
--
"Having a smoking section in a restaurant is like having
a peeing section in a swimming pool." -- Edward Burr