texinfo-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[8251] get converter class from string


From: gavinsmith0123
Subject: [8251] get converter class from string
Date: Sun, 30 Sep 2018 05:12:54 -0400 (EDT)

Revision: 8251
          http://svn.sv.gnu.org/viewvc/?view=rev&root=texinfo&revision=8251
Author:   gavin
Date:     2018-09-30 05:12:53 -0400 (Sun, 30 Sep 2018)
Log Message:
-----------
get converter class from string

Modified Paths:
--------------
    trunk/ChangeLog
    trunk/tp/texi2any.pl

Modified: trunk/ChangeLog
===================================================================
--- trunk/ChangeLog     2018-09-30 07:43:49 UTC (rev 8250)
+++ trunk/ChangeLog     2018-09-30 09:12:53 UTC (rev 8251)
@@ -1,5 +1,11 @@
 2018-09-30  Gavin Smith  <address@hidden>
 
+       * tp/texi2any.pl: Get class of converter from string value, 
+       rather than calling ref on a subroutine.  This subroutine would
+       actually be called, which is not the intention.
+
+2018-09-30  Gavin Smith  <address@hidden>
+
        * tp/tests/layout/list-of-tests, tp/t/93layout.t
        (navigation_section_no_header navigation_node_no_header)
        (navigation_chapter_vertical navigation_section_vertical)

Modified: trunk/tp/texi2any.pl
===================================================================
--- trunk/tp/texi2any.pl        2018-09-30 07:43:49 UTC (rev 8250)
+++ trunk/tp/texi2any.pl        2018-09-30 09:12:53 UTC (rev 8251)
@@ -1094,9 +1094,8 @@
         .'->converter(@_)};';
 }
 
-# This gets the class right, even though there is a sub...
-if (defined($formats_table{$format}->{'converter'})) {
-  $converter_class = ref(&{$formats_table{$format}->{'converter'}});
+if (defined($formats_table{$format}->{'module'})) {
+  $converter_class = $formats_table{$format}->{'module'};
   %converter_defaults = $converter_class->converter_defaults();
 }
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]