[no subject]

[Patrice Dumas]

branch: master
commit 9cf2be8b2ffb54a999bca191b22f7556f477b298
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Sun Jun 16 22:22:21 2024 +0200

    * tp/Texinfo/XS/main/manipulate_tree.c (copy_associated_info): use
    the newly initialized string list instead of allocating another one.
---
 ChangeLog                            | 5 +++++
 tp/TODO                              | 8 ++++----
 tp/Texinfo/XS/main/manipulate_tree.c | 2 +-
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 1339860382..dd07b798e9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -3,6 +3,11 @@
        * tp/Texinfo/XS/convert/convert_html.c (html_command_description):
        update for move of cmd to CONTAINER.
 
+2024-06-16  Patrice Dumas  <pertusus@free.fr>
+
+       * tp/Texinfo/XS/main/manipulate_tree.c (copy_associated_info): use
+       the newly initialized string list instead of allocating another one.
+
 2024-06-16  Patrice Dumas  <pertusus@free.fr>
 
        * tp/Texinfo/XS/main/command_stack.c
diff --git a/tp/TODO b/tp/TODO
index 1a4a26fbbe..262b0d20b6 100644
--- a/tp/TODO
+++ b/tp/TODO
@@ -78,13 +78,13 @@ ms_print massif_info.out > ms_print_info.out
     in use over time) conversion
 
 With full XS (7.2 64M, with text separate 58.5M, without info_info 56M
-              with integer extra keys 54M)
+              with integer extra keys 54M, with source marks as pointers 52.3M)
 valgrind --tool=massif --massif-out-file=massif_html.out perl -w texi2any.pl 
--html ../doc/texinfo.texi
 ms_print massif_html.out > ms_print_html.out
 useful-heap
 25M = 13.1 + 5.8 + 2.9 + 2.5 + 0.7 Perl
-19.5M Tree
- 6.7 + 6 = 12.7M new_element
+17.8M Tree
+ 6 + 5 = 11M new_element
  3.5M reallocate_list
  0.5M get_associated_info_key (below threshold in later reports)
  2.8M = 0.8 + 0.7 +1.3 text
@@ -93,7 +93,7 @@ useful-heap
                   (+1.3M by approximate difference with total)
 (7.5 + 1.3) - (3.8 + 0.7 + 0.7 + 0.8 +1.3) = 1.5 M Text not imputed
 3. - 0.5 = 2.5M remaining not imputed (- get_associated_info_key)
-53.7M TOTAL (for 54M reported)
+52M TOTAL (for 52.3M reported)
 
 
 check for comma after @xref{...}, in parser to simplify checking for
diff --git a/tp/Texinfo/XS/main/manipulate_tree.c 
b/tp/Texinfo/XS/main/manipulate_tree.c
index 8adcf4183b..e74d216467 100644
--- a/tp/Texinfo/XS/main/manipulate_tree.c
+++ b/tp/Texinfo/XS/main/manipulate_tree.c
@@ -124,7 +124,7 @@ copy_associated_info (ASSOCIATED_INFO *info, 
ASSOCIATED_INFO* new_info)
           {
           KEY_PAIR *k = get_associated_info_key (new_info, key, k_ref->type);
           k->k.strings_list = new_string_list();
-          copy_strings (new_string_list(), k_ref->k.strings_list);
+          copy_strings (k->k.strings_list, k_ref->k.strings_list);
           break;
           }
         case extra_index_entry: