[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[no subject]
From: |
Patrice Dumas |
Date: |
Sun, 29 Sep 2024 08:47:15 -0400 (EDT) |
branch: master
commit 5d2b6411c85098010fbe5b273f7cf1d81ceb8156
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Wed Jun 26 13:02:45 2024 +0200
Change in FIXME/TODO comments
---
tp/Texinfo/XS/convert/convert_html.c | 4 +++-
tp/Texinfo/XS/parsetexi/end_line.c | 10 ++++++++--
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/tp/Texinfo/XS/convert/convert_html.c
b/tp/Texinfo/XS/convert/convert_html.c
index e549b81124..f4307fd745 100644
--- a/tp/Texinfo/XS/convert/convert_html.c
+++ b/tp/Texinfo/XS/convert/convert_html.c
@@ -6269,7 +6269,9 @@ html_default_format_heading_text (CONVERTER *self, const
enum command_id cmd,
else
{
/* TODO if defaults of converter options become more used in C code,
- setup a structure with options defaults instead of hardcoding */
+ it could be relevant to predefine a table with code generated
+ by a specific Perl script with options defaults instead of
+ hardcoding */
int max_header_level = 4;
if (self->conf->MAX_HEADER_LEVEL.o.integer >= 1)
max_header_level = self->conf->MAX_HEADER_LEVEL.o.integer;
diff --git a/tp/Texinfo/XS/parsetexi/end_line.c
b/tp/Texinfo/XS/parsetexi/end_line.c
index 3a73b9bc89..6e120699bc 100644
--- a/tp/Texinfo/XS/parsetexi/end_line.c
+++ b/tp/Texinfo/XS/parsetexi/end_line.c
@@ -1904,8 +1904,14 @@ end_line (ELEMENT *current)
in a style brace @-command */
current = end_paragraph (current, 0, 0);
}
- /* FIXME not sure about this one, could be better to close
- brace commands in more contexts.
+ /* TODO Would it be better to have empty line close brace commands
+ in more contexts than paragraph and base? Empty line cannot happen
+ in some contexts, so a decision needs to be made where empty lines
+ are ok and do not stop the context:
+ ct_preformatted, ct_rawpreformatted, ct_math and ct_inlineraw.
+ It could possibly make sense not to close every brace command,
+ inlineraw for instance may not be closed by an empty line, at least
+ in some contexts.
*/
else if (current_context () == ct_base)
{ /* closes no_paragraph brace commands that are not context brace