[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
branch master updated: Remove N_UpdateTags, it is set but never checked
From: |
Patrice Dumas |
Subject: |
branch master updated: Remove N_UpdateTags, it is set but never checked |
Date: |
Wed, 09 Oct 2024 15:23:48 -0400 |
This is an automated email from the git hooks/post-receive script.
pertusus pushed a commit to branch master
in repository texinfo.
The following commit(s) were added to refs/heads/master by this push:
new 9b8e1c731d Remove N_UpdateTags, it is set but never checked
9b8e1c731d is described below
commit 9b8e1c731d38bb8e91d9535640098492f05e8dd2
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Wed Oct 9 21:23:36 2024 +0200
Remove N_UpdateTags, it is set but never checked
* info/nodes.c (adjust_nodestart): do not set N_UpdateTags in
node->flags as it is not checked anywhere, and nodestart_adjusted
is set right away for the tag, not need to change the tag further.
---
ChangeLog | 8 ++++++++
info/nodes.c | 11 +++--------
info/nodes.h | 1 -
3 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index aeb82b93c9..4b9ce5f2ee 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2024-10-09 Patrice Dumas <pertusus@free.fr>
+
+ Remove N_UpdateTags, it is set but never checked
+
+ * info/nodes.c (adjust_nodestart): do not set N_UpdateTags in
+ node->flags as it is not checked anywhere, and nodestart_adjusted
+ is set right away for the tag, not need to change the tag further.
+
2024-10-09 Patrice Dumas <pertusus@free.fr>
* info/window.c (window_log_to_phys_line): use consistent type.
diff --git a/info/nodes.c b/info/nodes.c
index 154933f68d..c00d3ed002 100644
--- a/info/nodes.c
+++ b/info/nodes.c
@@ -1116,10 +1116,10 @@ info_get_node_of_file_buffer (FILE_BUFFER *file_buffer,
char *nodename)
/* Find the actual starting memory location of NODE. Because of the
way that tags are implemented, the physical nodestart may
- not actually be where the tag says it is. If that is the case,
- set N_UpdateTags in NODE->flags. If the node is found, return non-zero.
+ not actually be where the tag says it is.
Set NODE->nodestart_adjusted directly on the separator that precedes this
- node. If the node could not be found, return 0. */
+ node. If the node is found, return non-zero. If the node could not be
+ found, return 0. */
static int
adjust_nodestart (FILE_BUFFER *fb, TAG *node)
{
@@ -1171,11 +1171,6 @@ adjust_nodestart (FILE_BUFFER *fb, TAG *node)
/* If the node still couldn't be found, we lose big. */
if (position == -1)
return 0;
-
- /* Set the flag in NODE->flags to say that the the tags table could
- need updating (if we used a tag to get here, that is). */
- if (node->flags & N_HasTagsTable)
- node->flags |= N_UpdateTags;
}
node->nodestart_adjusted = s.buffer + position - fb->contents;
diff --git a/info/nodes.h b/info/nodes.h
index 02bba9925b..6e317b99a0 100644
--- a/info/nodes.h
+++ b/info/nodes.h
@@ -56,7 +56,6 @@ typedef struct {
/* Values for NODE.flags or FILE_BUFFER.flags. */
#define N_HasTagsTable 0x01 /* This node was found through a tags table. */
#define N_TagsIndirect 0x02 /* The tags table was an indirect one. */
-#define N_UpdateTags 0x04 /* The tags table is out of date. */
#define N_IsCompressed 0x08 /* The file is compressed on disk. */
#define N_IsInternal 0x10 /* This node was made by Info. */
#define N_CannotGC 0x20 /* File buffer cannot be gc'ed. */
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- branch master updated: Remove N_UpdateTags, it is set but never checked,
Patrice Dumas <=