texinfo-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

branch master updated: * tp/Texinfo/XS/main/DocumentXS.xs (gdt): add mis


From: Patrice Dumas
Subject: branch master updated: * tp/Texinfo/XS/main/DocumentXS.xs (gdt): add missing braces for block. (Note that the corresponding code is not used).
Date: Fri, 11 Oct 2024 04:41:58 -0400

This is an automated email from the git hooks/post-receive script.

pertusus pushed a commit to branch master
in repository texinfo.

The following commit(s) were added to refs/heads/master by this push:
     new 45cb433d30 * tp/Texinfo/XS/main/DocumentXS.xs (gdt): add missing 
braces for block.  (Note that the corresponding code is not used).
45cb433d30 is described below

commit 45cb433d307785f18430f17e719dee6a78ebb9c0
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Fri Oct 11 10:41:47 2024 +0200

    * tp/Texinfo/XS/main/DocumentXS.xs (gdt): add missing braces for
    block.  (Note that the corresponding code is not used).
---
 ChangeLog                        |  5 +++++
 tp/Texinfo/XS/main/DocumentXS.xs | 32 +++++++++++++++++---------------
 2 files changed, 22 insertions(+), 15 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 2b23d8b1f7..6b54088c7c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2024-11-10  Patrice Dumas  <pertusus@free.fr>
+
+       * tp/Texinfo/XS/main/DocumentXS.xs (gdt): add missing braces for
+       block.  (Note that the corresponding code is not used).
+
 2024-11-10  Patrice Dumas  <pertusus@free.fr>
 
        * tp/Texinfo/XS/convert/format_html.c (html_internal_command_tree):
diff --git a/tp/Texinfo/XS/main/DocumentXS.xs b/tp/Texinfo/XS/main/DocumentXS.xs
index 1b7f5e563f..e726720827 100644
--- a/tp/Texinfo/XS/main/DocumentXS.xs
+++ b/tp/Texinfo/XS/main/DocumentXS.xs
@@ -397,21 +397,23 @@ gdt (string, ...)
              hv_replaced_substrings = (HV *)SvRV (ST(2));
              hv_number = hv_iterinit (hv_replaced_substrings);
              if (hv_number > 0)
-               replaced_substrings = new_named_string_element_list ();
-               for (i = 0; i < hv_number; i++)
-                 {
-                   char *key;
-                   I32 retlen;
-                   SV *value = hv_iternextsv(hv_replaced_substrings,
-                                             &key, &retlen);
-                   DOCUMENT *document = get_sv_tree_document (value, 0);
-                   /* TODO should warn/error if not found or return
-                      a list of missing string identifiers?  Or check
-                      in caller?  In any case, it cannot be good to
-                      ignore a replaced substring */
-                   if (document && document->tree)
-                     add_element_to_named_string_element_list (
-                       replaced_substrings, key, document->tree);
+               {
+                 replaced_substrings = new_named_string_element_list ();
+                 for (i = 0; i < hv_number; i++)
+                   {
+                     char *key;
+                     I32 retlen;
+                     SV *value = hv_iternextsv(hv_replaced_substrings,
+                                               &key, &retlen);
+                     DOCUMENT *document = get_sv_tree_document (value, 0);
+                     /* TODO should warn/error if not found or return
+                        a list of missing string identifiers?  Or check
+                        in caller?  In any case, it cannot be good to
+                        ignore a replaced substring */
+                     if (document && document->tree)
+                       add_element_to_named_string_element_list (
+                         replaced_substrings, key, document->tree);
+                   }
                }
            }
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]