branch master updated: * tp/Texinfo/XS/convert/ConvertXS.xs, tp/Texinfo/XS/convert/get_converter_perl_info.c, tp/Texinfo/XS/convert/get_html_perl_info.c, tp/Texinfo/XS/main/get_perl_info.c, tp/Texinfo/XS/parsetexi/Parsetexi.xs: remove ppport.h include following ppport.h advice. Do not follow ppport.h suggestion for call_html_perl_function.c as we use G_LIST, which is not portable.

[Patrice Dumas]

This is an automated email from the git hooks/post-receive script.

pertusus pushed a commit to branch master
in repository texinfo.

The following commit(s) were added to refs/heads/master by this push:
     new 19223d381d * tp/Texinfo/XS/convert/ConvertXS.xs, 
tp/Texinfo/XS/convert/get_converter_perl_info.c, 
tp/Texinfo/XS/convert/get_html_perl_info.c, tp/Texinfo/XS/main/get_perl_info.c, 
tp/Texinfo/XS/parsetexi/Parsetexi.xs: remove ppport.h include following 
ppport.h advice.  Do not follow ppport.h suggestion for 
call_html_perl_function.c as we use G_LIST, which is not portable.
19223d381d is described below

commit 19223d381d12bf5898890b51d44914b6cd37203f
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Sat Nov 16 18:24:53 2024 +0100

    * tp/Texinfo/XS/convert/ConvertXS.xs,
    tp/Texinfo/XS/convert/get_converter_perl_info.c,
    tp/Texinfo/XS/convert/get_html_perl_info.c,
    tp/Texinfo/XS/main/get_perl_info.c,
    tp/Texinfo/XS/parsetexi/Parsetexi.xs: remove ppport.h include
    following ppport.h advice.  Do not follow ppport.h suggestion for
    call_html_perl_function.c as we use G_LIST, which is not portable.
    
    * tp/Texinfo/XS/convert/get_html_perl_info.c
    (html_converter_get_customization_sv): move FETCH definition down
    where it is used.
---
 ChangeLog                                       | 14 ++++++++++++++
 tp/Texinfo/XS/convert/ConvertXS.xs              |  1 -
 tp/Texinfo/XS/convert/call_html_perl_function.c |  2 ++
 tp/Texinfo/XS/convert/get_converter_perl_info.c |  2 --
 tp/Texinfo/XS/convert/get_html_perl_info.c      |  9 ++-------
 tp/Texinfo/XS/main/get_perl_info.c              |  2 --
 tp/Texinfo/XS/parsetexi/Parsetexi.xs            |  1 -
 7 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 840a87f24e..147b5a0c60 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,17 @@
+2024-11-16  Patrice Dumas  <pertusus@free.fr>
+
+       * tp/Texinfo/XS/convert/ConvertXS.xs,
+       tp/Texinfo/XS/convert/get_converter_perl_info.c,
+       tp/Texinfo/XS/convert/get_html_perl_info.c,
+       tp/Texinfo/XS/main/get_perl_info.c,
+       tp/Texinfo/XS/parsetexi/Parsetexi.xs: remove ppport.h include
+       following ppport.h advice.  Do not follow ppport.h suggestion for
+       call_html_perl_function.c as we use G_LIST, which is not portable.
+
+       * tp/Texinfo/XS/convert/get_html_perl_info.c
+       (html_converter_get_customization_sv): move FETCH definition down
+       where it is used.
+
 2024-11-16  Gavin Smith <gavinsmith0123@gmail.com>
 
        * tp/tests/many_input_files/tex_l2h_output_dir_non_ascii.sh,
diff --git a/tp/Texinfo/XS/convert/ConvertXS.xs 
b/tp/Texinfo/XS/convert/ConvertXS.xs
index 08d3c0247f..5a68337930 100644
--- a/tp/Texinfo/XS/convert/ConvertXS.xs
+++ b/tp/Texinfo/XS/convert/ConvertXS.xs
@@ -24,7 +24,6 @@
 #include "EXTERN.h"
 #include "perl.h"
 #include "XSUB.h"
-#include "ppport.h"
 
 #undef context
 
diff --git a/tp/Texinfo/XS/convert/call_html_perl_function.c 
b/tp/Texinfo/XS/convert/call_html_perl_function.c
index d26328be9b..8a000005d4 100644
--- a/tp/Texinfo/XS/convert/call_html_perl_function.c
+++ b/tp/Texinfo/XS/convert/call_html_perl_function.c
@@ -20,6 +20,8 @@
 #include "EXTERN.h"
 #include "perl.h"
 #include "XSUB.h"
+/* ppport.h suggests to remove its include, but we need it to
+   replace G_LIST by G_ARRAY if G_LIST is not defined */
 #include "ppport.h"
 
 #undef context
diff --git a/tp/Texinfo/XS/convert/get_converter_perl_info.c 
b/tp/Texinfo/XS/convert/get_converter_perl_info.c
index baca04708f..3fc60cc641 100644
--- a/tp/Texinfo/XS/convert/get_converter_perl_info.c
+++ b/tp/Texinfo/XS/convert/get_converter_perl_info.c
@@ -24,8 +24,6 @@
 #include "perl.h"
 #include "XSUB.h"
 
-#include "ppport.h"
-
 #undef context
 
 #include "command_ids.h"
diff --git a/tp/Texinfo/XS/convert/get_html_perl_info.c 
b/tp/Texinfo/XS/convert/get_html_perl_info.c
index 55d1976cb4..6942872308 100644
--- a/tp/Texinfo/XS/convert/get_html_perl_info.c
+++ b/tp/Texinfo/XS/convert/get_html_perl_info.c
@@ -24,8 +24,6 @@
 #include "perl.h"
 #include "XSUB.h"
 
-#include "ppport.h"
-
 #undef context
 
 #include "html_conversion_data.h"
@@ -892,11 +890,6 @@ html_converter_get_customization_sv (SV *converter_sv,
         }
     }
 
-#define FETCH(key) key##_sv = hv_fetch (converter_hv, #key, strlen (#key), 0);
-   /*
-  FETCH(htmlxref)
-    */
-
   /* Get htmlxref from Perl.
      this is always 0 as it is not fetch so this code is never run, htmlxref
      information is setup in C.
@@ -944,6 +937,8 @@ html_converter_get_customization_sv (SV *converter_sv,
         }
     }
 
+#define FETCH(key) key##_sv = hv_fetch (converter_hv, #key, strlen (#key), 0);
+
   FETCH(formatting_function);
 
   /* no need to check if it exists */
diff --git a/tp/Texinfo/XS/main/get_perl_info.c 
b/tp/Texinfo/XS/main/get_perl_info.c
index cae30ed5c3..bd2a7b4124 100644
--- a/tp/Texinfo/XS/main/get_perl_info.c
+++ b/tp/Texinfo/XS/main/get_perl_info.c
@@ -23,8 +23,6 @@
 #include "perl.h"
 #include "XSUB.h"
 
-#include "ppport.h"
-
 #undef context
 
 #include "text.h"
diff --git a/tp/Texinfo/XS/parsetexi/Parsetexi.xs 
b/tp/Texinfo/XS/parsetexi/Parsetexi.xs
index d170bf5716..2bc55dde8b 100644
--- a/tp/Texinfo/XS/parsetexi/Parsetexi.xs
+++ b/tp/Texinfo/XS/parsetexi/Parsetexi.xs
@@ -36,7 +36,6 @@
 #endif
  */
 #include "XSUB.h"
-#include "ppport.h"
 
 #undef context