texinfo-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

branch master updated: * configure.ac, tp/Texinfo/XS/configure.ac: add c


From: Patrice Dumas
Subject: branch master updated: * configure.ac, tp/Texinfo/XS/configure.ac: add comments and TODO describing that --enable-xs-perl-libintl can be useful on platforms where gettext functions are present, but setting the locale through LANGUAGE is not implemented, as is the case for musl.
Date: Mon, 16 Dec 2024 17:23:19 -0500

This is an automated email from the git hooks/post-receive script.

pertusus pushed a commit to branch master
in repository texinfo.

The following commit(s) were added to refs/heads/master by this push:
     new 97dd9efa96 * configure.ac, tp/Texinfo/XS/configure.ac: add comments 
and TODO describing that --enable-xs-perl-libintl can be useful on platforms 
where gettext functions are present, but setting the locale through LANGUAGE is 
not implemented, as is the case for musl.
97dd9efa96 is described below

commit 97dd9efa968fb7377aa77503df8e1cda9764e081
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Mon Dec 16 23:23:14 2024 +0100

    * configure.ac, tp/Texinfo/XS/configure.ac: add comments and TODO
    describing that --enable-xs-perl-libintl can be useful on platforms
    where gettext functions are present, but setting the locale through
    LANGUAGE is not implemented, as is the case for musl.
---
 ChangeLog                  | 9 ++++++++-
 configure.ac               | 7 +++++++
 tp/Texinfo/XS/configure.ac | 7 ++++---
 3 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 4b920c72d1..60320bef8c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2024-12-16  Patrice Dumas  <pertusus@free.fr>
+
+       * configure.ac, tp/Texinfo/XS/configure.ac: add comments and TODO
+       describing that --enable-xs-perl-libintl can be useful on platforms
+       where gettext functions are present, but setting the locale through
+       LANGUAGE is not implemented, as is the case for musl.
+
 2024-12-16  Patrice Dumas  <pertusus@free.fr>
 
        * doc/texinfo.texi (small): mention that @small... commands
@@ -7,7 +14,7 @@
 
        * tp/Texinfo/XS/main/translations.c (translate_string): if ENABLE_NLS
        is not set, remove completly the code calling functions in include
-       fils included only if ENABLE_NLS is set.
+       files included only if ENABLE_NLS is set.
 
        * tp/Texinfo/XS/main/translations.c
        (configure_output_strings_translations): unindent cpp directives for
diff --git a/configure.ac b/configure.ac
index 9709bdfa65..41bd18073b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -502,6 +502,13 @@ AC_SUBST([enable_xs])
 
 AM_CONDITIONAL([DISABLE_XS], [test "z$enable_xs" = zno])
 
+# This is useful on platforms where gettext functions are present, but
+# setting the locale through LANGUAGE is not implemented.  In 2024 this is
+# the case of the musl libc libintl implementation, for example.
+# Setting locale through LANGUAGE is not automatically detected, but it
+# is possible to manually set --enable-xs-perl-libintl to use libintl-perl
+# to always get the correct output (there is a TODO for automatic detection in
+# tp/Texinfo/XS/configure.ac).
 AC_ARG_ENABLE([xs-perl-libintl],
     AS_HELP_STRING([--enable-xs-perl-libintl],
             [prefer Perl libintl-perl gettext in XS modules]),
diff --git a/tp/Texinfo/XS/configure.ac b/tp/Texinfo/XS/configure.ac
index 7c22e68f0a..96655fbd1a 100644
--- a/tp/Texinfo/XS/configure.ac
+++ b/tp/Texinfo/XS/configure.ac
@@ -197,9 +197,8 @@ LT_INIT([disable-static dlopen])
 AM_CONDITIONAL([HAVE_ICONV],
                [test "x$am_func_iconv" = "xyes"])
 
-# This switch was added when there were issues on some platforms with
-# the locales switch for output strings translations when done in C.
-# Now that it is fixed, it could be removed.
+# This is useful on platforms where gettext functions are present, but
+# setting the locale through LANGUAGE is not implemented.
 AC_ARG_ENABLE([xs-perl-libintl],
     AS_HELP_STRING([--enable-xs-perl-libintl],
               [prefer Perl libintl-perl gettext in XS modules]),
@@ -211,6 +210,8 @@ AC_ARG_ENABLE([xs-perl-libintl],
      [
       if test $usable_getenv_in_XS = yes ; then
         use_libintl_perl_in_xs=no
+        # TODO add a check of working C libintl gettext for the locale
+        # switching using LANGUAGE and translated output string retrieval
       else
         use_libintl_perl_in_xs=yes
       fi



reply via email to

[Prev in Thread] Current Thread [Next in Thread]